Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of typesetPromise in defaultPageReady. (mathjax/MathJax#3130) #1018

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Nov 13, 2023

This PR fixes a problem with defaultPageReady() where the typesetting could be done at the wrong time. With this PR, it should be performed when the then() is triggered, whereas before it was done when the defaultPageReady() call was made (OOPS!).

Resolves issue mathjax/MathJax#3130.

@dpvc dpvc requested a review from zorkow November 13, 2023 16:27
@dpvc dpvc added this to the v4.0 milestone Nov 13, 2023
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit dd7481c into develop Nov 20, 2023
@dpvc dpvc deleted the issue3130 branch November 20, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants