Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have \unicode check for illegal font name. (mathjax/MathJax#3129) #1019

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Nov 13, 2023

This PR adds a check that the font name doesn't include semicolons in the \unicode macro. This prevents extra CSS from being inserted into the styles for the resulting output.

Resolves issue mathjax/MathJax#3129.

@dpvc dpvc requested a review from zorkow November 13, 2023 16:36
@dpvc dpvc added this to the v4.0 milestone Nov 13, 2023
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 42437fb into develop Nov 20, 2023
@dpvc dpvc deleted the issue3129 branch November 20, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants