Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnpm move #1021

Merged
merged 22 commits into from
Nov 28, 2023
Merged

Pnpm move #1021

merged 22 commits into from
Nov 28, 2023

Conversation

zorkow
Copy link
Member

@zorkow zorkow commented Nov 14, 2023

Changes build system to pnpm. Major changes are:

  • pnpm does not run pre and post hooks for custom scripts. (They still work for lifecycle scripts).
  • Scripts are now separated topically into CJS and MJS scripts. There all still some general scripts of copy, clean, etc.
  • Scripts try to make the execution flow as transparent as possible. They are mainly separated into two types
    • Compound scripts that execute multiple. They produce blue logging output.
    • Single scripts that execute a single command or action. They produce brown output.
  • All scripts use : separation to construct names as meaningful as possible. Exception are some legacy script names - now mainly aliases - like make-components.
  • The link:full does not have to execute explicitly anymore
  • clean also removes bundle-cjs
  • pack now uses pnpm instead of npx. However, the former needs to be executed in the root directory of the repository. So the paths need to be given relative to root and not to the directory of the component that is packed.
  • Replaces all occurrences of substr in the node scripts with substring.

@zorkow zorkow requested a review from dpvc November 14, 2023 14:32
@zorkow zorkow changed the base branch from master to develop November 14, 2023 14:44
@dpvc dpvc added this to the v4.0 milestone Nov 20, 2023
@zorkow
Copy link
Member Author

zorkow commented Nov 23, 2023

Made changes as discussed in PR #1023

Copy link
Member

@dpvc dpvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last potential change, but otherwise looks good.

package.json Outdated Show resolved Hide resolved
@zorkow zorkow merged commit 9f1fdae into develop Nov 28, 2023
@zorkow zorkow deleted the pnpm_move branch November 28, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants