Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear process bits for findMath and attach-speech, and remove safe bit that isn't needed. #1034

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Dec 18, 2023

When the document state is reset, the process bits should be reset for the actions that are for higher states. This wasn't happening for the attach-speech bit in the semantic-enrich extension. I did a check to make sure all the other bits are bing properly handled, and the findMath bit was not being recent properly, either. Also, a safe bit was being allocated that was never used. This PR fixes these three problems.

Resolve issues raised in a user's forum post.

@dpvc dpvc requested a review from zorkow December 18, 2023 18:21
@dpvc dpvc added this to the v4.0 milestone Dec 18, 2023
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 0be2b55 into develop Dec 28, 2023
@dpvc dpvc deleted the fix-bits branch December 28, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants