Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure math item have their metrics set before lazy typesetting. (mathjax/MathJax#3167) #1042

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jan 24, 2024

This PR resolves a problem when the lazy typesetter is used with the assistive MathML extension and the initial typesetting is disabled with SVG output. In that case, any math that is showing initially will get a bad viewBox for their svg element due to the fact that the metrics for the surrounding font haven't been computed. We fix this by checking whether the metrics are available and setting the state to before the measuring of metrics in that case.

Resolves issue mathjax/MathJax#3167.

@dpvc dpvc requested a review from zorkow January 24, 2024 22:36
@dpvc dpvc added this to the v4.0 milestone Jan 24, 2024
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 2beae4f into develop Feb 1, 2024
@dpvc dpvc deleted the issue3167 branch February 1, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants