Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LiteParser's serializeXML. (mathjax/MathJax-demos-node#58) #1046

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jan 28, 2024

This PR fixes two problems with the LiteDOM serializeXML() method. It protects < and > in attributes, which is not needed for HTML, but is for XHTML, and it adds namespaces for html, svg, and math elements, if they don't already have one.

Resolves an issue from mathjax/MathJax-demos-node#58.

@dpvc dpvc requested a review from zorkow January 28, 2024 22:22
@dpvc dpvc added this to the v4.0 milestone Jan 28, 2024
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 96c1018 into develop Feb 6, 2024
@dpvc dpvc deleted the xml-fixes branch February 6, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants