Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TexParser.Push() handle inferred mrows properly. mathjax/MathJax#2261 #415

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Dec 30, 2019

Make TexParser.Push() handle inferred mrow by pushing the children instead of the inferred mrow itself. Elements that take inferred mrow as children create them automatically, and inferred mrows should not be pushed directly. They are created by ParseArg() as a means of identifying collections of elements that need to be pushed separately, but that wasn't being done. This PR fixes that oversight.

Resolves issue mathjax/MathJax#2261.

@dpvc dpvc requested a review from zorkow December 30, 2019 21:57
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 1c795b8 into develop Jan 23, 2020
@dpvc dpvc deleted the issue2261 branch January 23, 2020 18:11
@dpvc dpvc added this to the 3.0.1 milestone Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants