Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with munderover/msubsup when base is scaled (mathjax/MathJax#2317) #456

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Fix issues with munderover/msubsup when base is scaled (mathjax/MathJax#2317) #456

merged 3 commits into from
Apr 3, 2020

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 16, 2020 •
edited
Loading

This PR fixes a number of script placement issues with munderover and msubsup when the base is scaled via <mstyle mathsize="...">.

Resolves issue mathjax/MathJax#2317.

@dpvc dpvc requested a review from zorkow March 16, 2020 19:21
@dpvc dpvc added this to the 3.0.2 milestone Mar 19, 2020
zorkow
zorkow approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things. O/w lgtm.

ts/output/chtml/Wrappers/msubsup.ts Outdated Show resolved Hide resolved
ts/output/svg/Wrappers/msubsup.ts Outdated Show resolved Hide resolved
@dpvc dpvc merged commit 6a05e03 into develop Apr 3, 2020
@dpvc dpvc deleted the issue2317 branch April 3, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpvc @zorkow