Fix problem with detecting whether ex-height can be computed, and work around jsdom problems #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in 3.1.3 that causes liteDOM and jsdom adapters to get the ex-height badly wrong. This was due to changes made to process CJK characters that also added some default height, which confused the test to see if the
exFactorneeded to be used.There are also some problems with jsdom's implementation of
getComputesStyle(), which doesn't actually inherit styles, it only lists the ones explicitly on the given element. The CSSStyleDeclaration implementation is broken in a number of ways, and I've had to patch it before, but this issue would take some work. This PR adds options to the jsdom to set the font size and family to use (just as we do with the LiteDOM), sincegetComputedStyle()can't be trusted.Resolves issue mathjax/MathJax#2694.