Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim delimiter for \big and friends, and put \math* in a TeXAtom (mathjax/MathJax#2688, mathjax/MathJax#2689) #698

Merged
merged 1 commit into from
May 24, 2021

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented May 11, 2021

This PR fixes some issues reported by Peter.

  1. \bigg{\uparrow } indicates an error (the trailing space was not being removed).
  2. \mathbf{x^x}^x produces an error (the \mathbf{...} should be in a TeXAtom of type ORD.

Resolves issue mathjax/MathJax#2688 and mathjax/MathJax#2689.

@dpvc dpvc requested a review from zorkow May 11, 2021 21:00
@dpvc dpvc added this to the 3.2 milestone May 11, 2021
@dpvc dpvc changed the title Trim delimiter for \big and friends, and put \math* in a TeXAtom Trim delimiter for \big and friends, and put \math* in a TeXAtom (mathjax/MathJax#2688, mathjax/MathJax#2689) May 11, 2021
@pkra
Copy link
Contributor

pkra commented May 12, 2021

Thanks for the quick fixes! I'll test them out this week.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 33d84d5 into develop May 24, 2021
@dpvc dpvc deleted the minor-fixes branch May 24, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants