Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with msubsup when subscript is blank (mathjax/MathJax#2765) #742

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Sep 15, 2021

This PR fixes an issue in CommonHTML output where msubsup output when the subscript is empty shows the superscript in the subscript position in some instances (see the initial issue mathjax/MathJax#2765). This was caused by CSS that was overriding the display property for the super- and subscript elements, when it really only needed to be for the spacer. The order in which the CSS for the msubsup and the scripts are output also affected the results. The fix is to limit the CSS to just the spacer.

Resolves issue mathjax/MathJax#2765.

@dpvc dpvc requested a review from zorkow September 15, 2021 21:34
@EricDunsworth
Copy link
Contributor

@dpvc Did you mean to say "shows the superscript in the subscript position" in the OP?

@dpvc
Copy link
Member Author

dpvc commented Sep 17, 2021

@EricDunsworth, yes, thanks. I've corrected the statement.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dpvc dpvc merged commit f9c8df5 into develop Feb 22, 2022
@dpvc dpvc deleted the issue2765 branch February 22, 2022 13:26
@dpvc dpvc added this to the 3.2.1 milestone Feb 22, 2022
@dpvc dpvc changed the title Fix problem with msubsup when subscript is blank (#2765) Fix problem with msubsup when subscript is blank (mathjax/MathJax#2765) Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants