Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial value to reduce() calls to avoid problems with empty arrays. #74 #75

Merged
merged 2 commits into from
Mar 5, 2018
Merged

Add initial value to reduce() calls to avoid problems with empty arrays. #74 #75

merged 2 commits into from
Mar 5, 2018

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Dec 13, 2017

Resolves issue #74 by adding initial values to the reduce() calls.

zorkow
zorkow requested changes Feb 14, 2018
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please stretch that out a bit at the chaining dots to improve readability? In particular the map-reduce parts.

@dpvc
Copy link
Member Author

dpvc commented Feb 16, 2018

Can you please stretch that out a bit

OK, see if that is better.

zorkow
zorkow approved these changes Mar 2, 2018
View reviewed changes
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dpvc dpvc merged commit a439df8 into ie-stretchy-braces Mar 5, 2018
@dpvc dpvc deleted the issue74 branch March 5, 2018 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
in current beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpvc @zorkow