Fix problems with verification and repair of malformed mtables. #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Feb 22, 2022
… than multiple mtr), as requested by Volker. Also, add a removeChild() method to the Node class.
That sounds good. I've pushed commits that does that. See if that is more to your liking. |
zorkow
approved these changes
Apr 6, 2022
ts/core/MmlTree/MmlNodes/mtable.ts
Outdated
| const isMtd = child.isKind('mtd'); | ||
| // | ||
| // If there is already an mtr for previous children, just remove the child | ||
| // otherwise repalce the child with a new mtr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR produces better results for repairing and reporting issues with malformed mtables. There are verification options available that are supposed to control the error messages produced for bad MathML, and one controls whether tables should be repaired silently or produce
merrorelements to report the problem. ThefixMtablesoption did not work well, as it did not produce proper messages in some cases, and didn't always produce a repaired table.The fixes here include:
voidbut returned anerrornode).mtrormtdelements are in a validmtable, and produce the right output (a coloredmtdwhen used outside anmtr, or a coloredmtrwhen used outside a table, and a colored entry when missing themtd.mtrandmtdelements are inserted to make a valid table regardless of the verification options (those only control the error reporting).