Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem where errors during mhchem argument collection are not properly handled. (mathjax/MathJax#2835) #786

Merged
merged 1 commit into from Feb 22, 2022

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Feb 19, 2022

This PR isolates the call to mhchemParser and in order to handle the different error format used by the TeX parser and the mhchem parser, as reported in mathjax/MathJax#2835.

Resolves issue mathjax/MathJax#2835.

@dpvc dpvc requested a review from zorkow February 19, 2022 00:14
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 2051212 into develop Feb 22, 2022
@dpvc dpvc deleted the issue2835 branch February 22, 2022 13:46
@dpvc dpvc added this to the 3.2.1 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants