Prevent CHTML adaptice CSS from adding character CSS multiple times #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CHTML adaptive CSS currently adds CSS rules for characters multiple times if they are used in multiple typeset calls. I.e., typesetting
$$x$$
, then adding another$$x$$
to the page and typesetting again will cause two copies of the CSS for the italic "x" to be added to the CHTML stylesheet.This is due to the fact that the usage tracking for the characters uses a
Set()
object with arrays that represent the variant and the character in that variant, but since two arrays are different even if they contain the same content, the fact that["italic", 0x1D465]
was already in the set was not being taken into account.This PR fixes the problem by using a string rather than the array as the element in the set. The original array is JSON stringified so that two copies of the arrays will be considered the same (while not disrupting the use as
Usage<number>
andUsage<string>
since numbers and strings stringify as themselves).