Make version.ts use a constant and create the file during the build process. (#818) #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Jun 8, 2022
Last time I found out by the fact that the publish run failed, and I tracked down the error message. Could always try that again. I will see if I can find something indicating the current state of affairs. |
|
The default OS used by Travis-CI is ubuntu 16.04, unless you request otherwise. It looks like node.js v18 changed the library version they use, and that ubuntu 16.04 doesn't have it, nor does 18.04; you need 18.10 or 20.04 to allow it to work. Travis-CI does have a 20.04 option, so I will switch to that and see if that allows the use of the stable version of node.js again. |
|
It looks like the update to 20.04 did the trick. Back to stable version of node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the build issue that was reported with v3.2.1 due to the dynamic lookup of the version number by creating the
version.tsfile viacomponents/bin/version, which is run during the travis-ci publish process (and can be run by hand at any point).Resolve issue #818 and mathjax/MathJax#2880