Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of template macros with no actual arguments. (mathjax/MathJax#2901) #838

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 19, 2022

If a macro definition has a template, but requires no arguments (e.g., \def\a\b{...}) then the template is not checked and not properly removed. This PR makes sure the template matches its usage, and removes it.

Resolves issue mathjax/MathJax#2901.

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc changed the base branch from master to develop August 12, 2022 17:30
@dpvc dpvc merged commit 6ff3939 into develop Aug 12, 2022
@dpvc dpvc deleted the issue2901 branch August 12, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants