Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lineWidth from the Metrics object, since it is never used. #936

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 18, 2023

This PR removes lineWidth from the Metrics object, since it is never used (it was targeted for line-breaking, but it turns out that it wasn't needed).

This will need documentation.

@dpvc dpvc requested a review from zorkow March 18, 2023 18:44
@dpvc dpvc added this to the v4.0 milestone Mar 18, 2023
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit d1cee77 into develop Apr 8, 2023
@dpvc dpvc deleted the remove-lineWidth branch April 8, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants