Change Symbol to Token to avoid conflict with native Symbol in webpacked files. (mathjax/MathJax#3072) #982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
Symbol
class name toToken
so that it doesn't conflict with the nativeSymbol
object in webpacked files. Webpacking of ESM files handles the exports from the componentlib
files as global variables, and that means theSymbol
object will overwrite the native one, and since the webpack initialization code refers toSymbol
before thatconst Symbol
is set up, that cause a compile error. (The old CommonJSmodules.export
approach didn't use separate global variables, so didn't have that problem.)Along with this, it renames
SymbolMap
toTokenMap
, and changes variables calledsymbol
totoken
, where appropriate.Unfortunately, this touches a lot of files.
Resolves issue mathjax/MathJax#3072.