Improve build tools for use with third-party extensions. (mathjax/MathJax#3086) #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes minor changes to the build tools so that they work better for third-party extensions.
The first change makes the build command have a better default for the
tsdirectory (is it now next to thejsdirectory, no matter what its name is).The changes to
packproduce better results for the file list when packing a file (the[build]files, which are the ones from the actual extension, will be at the top of the list, and the[js]will now be applied to file even if they are not in a mjs/cjs directory.The change to
webpack.common.cjsmakes sure that all references tomathjax-full/jsare remapped to the appropriate mjs/cjs version (without this, some were not getting caught, causing unwanted mathjax files to be included in the final packed file).Resolves some issue raised in mathjax/MathJax#3086.