changed optional argument syntax of \img command (img.js extension) to be more LaTeX-like

[burnpanck]

Optional arguments are now given either as

\img[valign=<valign>,width=<width>,height=<height>]{URL}

or

\img[<valign>][<width>][<height>]{URL}

which are both common ways to supply optional parameters in LaTeX (the latter is usually used when there is just one optional argument). Example in http://jsfiddle.net/c6sy534g/

[burnpanck]

Packed source was not yet updated, as I didn't come around yet to actually install MathJax's toolchain.

[pkra]

Thanks. I haven't had time to look in detail. But you can pack it any way you like; we don't have many for third-party extensions. Coudl you fill out http://www.mathjax.org/cla/ (and reply to the confirmation email)? We don't require this for third party extensions in general, but since this is one the MathJax team created and since it might eventually make it to the core repository, we'd need a CLA. Thanks!

[pkra]

Sorry for the delay. This looks good in general.

Perhaps the error messages could end in 'in %1' (which means "in \image" for this macro). Ideally, they would be localizable (but this can wait until this actually enteres the core). For both, cf. https://github.com/mathjax/MathJax/blob/master/unpacked/extensions/TeX/verb.js#L47

[pkra]

bump

[burnpanck]

like so?

[dpvc]

Note that the string trim() function is not available in IE8 and below, so this will cause those browsers to die. Perhaps using parts[0].replace(/^ +/,"").replace(/ +$/,"")would be better (if less efficient) here.

[pkra]

I clearly lost track of this. Can we merge this?

[dpvc]

Well, I had made some comments on the code that haven't been addressed. But since it was your extension to begin with, it is really up to you whether you want to accept the changes or not (or accept and then modify afterward).

I'm happy in principle with it, but do thing those few things could be altered.

[pkra]

Thanks, Davide.

@burnpanck are you ok with merging it or do you want to modify this further?

[burnpanck]

Sorry, my fault. I'm rather busy these days unfortunately. I did now apply the changes @dpvc suggested. With that I am ok to merge.

[pkra]

Thanks, @burnpanck -- that's great!