Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sqrtspacing extension <--- https://github.com/evgenystan/sqrtspacing #8

Merged
merged 4 commits into from
Jun 11, 2014

Conversation

evgenystan
Copy link
Contributor

Sqrtspacing is and extension for MathJax.

This extension improves visual rendering of square roots by adding a little bit of padding between the root and a non-whitespace math symbol that precedes or follows it. This unglues visually the root from the math around it.

@pkra
Copy link
Contributor

pkra commented Jun 11, 2014

First off, thank you for the pull request! Apologies for the lack of information in the repository README -- you're just too fast ;-) Your pull request is the first and we're still behind on that.

We're open to discussing how to organize this repository (e.g., whether we want something more along the lines of https://github.com/cdnjs/cdnjs/) but I think the following points are relatively straight forward (see the other extensions for how we did this there).

  • The loadComplete call should be of the form [Contrib]/foldername/filename.js to work generically with a third party location in MathJax v2.4+.
  • preferably, a packed (using uglify, YUI etc) and an unpacked version (unpacked version under foldername/unpacked with a working loadComplete call).
  • A README file with some basic information on the extension (see other extensions to get an idea)
  • A License.txt file (each extension should have its own license for portability and because we accept any Apache-2-compatible license)

Let me know if you have any questions.

@dpvc
Copy link
Member

dpvc commented Jun 11, 2014

There are some problems with the implementation. First, it only works for HTML-CSS output, so those who have selected SVG, for example, won't get the same result. I will make some comments in the code later once I've had the chance to test it more carefully.

@evgenystan
Copy link
Contributor Author

Davide,

Yes, this extension only works with HTML-CSS
I have not looked into the internals of the SVG renderer. However, if the logic of the renderer is similar to the HTML-CSS one, I can try to implement that one too.

Peter,
I have included readme and license test files. I'm working on minifying my script.

Be back soon.

@pkra
Copy link
Contributor

pkra commented Jun 11, 2014

@evgenystan thanks for adding the files! One typo: the compressed version is missing a slash in the loadComplete call.

@dpvc should we leave discussion of the approach for the dev-group?

@evgenystan
Copy link
Contributor Author

Ok.
Now it works with SVG renderer too. I also fixed the loadComplete call.

May I suggest we post guidelines and instructions for submitting extensions in the Wiki section. That seems to be the appropriate place for them.
Also, putting then in the read-me file would help the first timers.

Thank you for your interest.

@pkra
Copy link
Contributor

pkra commented Jun 11, 2014

Thanks! Good enough for me (but I didn't look at the code itself -- I suggest we discuss that on the dev-list).

I was planning on adding the instructions to this repository's README. Does that sound sensible?

@evgenystan
Copy link
Contributor Author

I would put the instructions and guidelines in both readme and wiki. Just to make sure no one misses them :-)

pkra pushed a commit that referenced this pull request Jun 11, 2014
@pkra pkra merged commit dd0d12e into mathjax:master Jun 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants