Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeX input: improve heuristics for invisible apply #1312

Closed
pkra opened this issue Nov 23, 2015 · 12 comments
Closed

TeX input: improve heuristics for invisible apply #1312

pkra opened this issue Nov 23, 2015 · 12 comments
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.6
Milestone

Comments

@pkra
Copy link
Contributor

pkra commented Nov 23, 2015

From the discussion at #1305 (comment)

The TeX input jax does put invisible times following things like \sin and \dim, but only in certain circumstances, and (unfortunately) that doesn't currently include when \dim is followed by another operator. The heuristic for adding invisible times could be altered to include more situations, and probably should.

@pkra pkra added the Accepted Issue has been reproduced by MathJax team label Nov 23, 2015
@pkra pkra added this to the MathJax v3.0 milestone Nov 23, 2015
@physikerwelt
Copy link
Contributor

I think we should collect some reasonable testcases:

\arcsin\sin\phi
\operatorname{x}\operatorname{y}

@dpvc
Copy link
Member

dpvc commented Dec 3, 2015

You also want

\sin\left(x\right)

as a test case (it doesn't currently get the function apply).

@dpvc
Copy link
Member

dpvc commented Dec 3, 2015

The issue1312 branch of my fork of MathJax implements an improved algorithm for adding the invisible function apply operation, and it does handle the three cases shown above.

@dpvc dpvc modified the milestones: MathJax v2.6, MathJax v3.0 Dec 3, 2015
dpvc added a commit to dpvc/MathJax that referenced this issue Dec 4, 2015
@dpvc
Copy link
Member

dpvc commented Dec 4, 2015

=> Merged.

@dpvc
Copy link
Member

dpvc commented Dec 5, 2015

=> In testsuite

LaTeXToMathML/issue1312.html

@physikerwelt
Copy link
Contributor

@dpvc Yes it works great. I did already cherry pick your change to mathoid.

@physikerwelt
Copy link
Contributor

@physikerwelt
Copy link
Contributor

... oh I see the space between \dim \mathrm{im}(f) is still missing... It sems that I did not check carefully enough this morning

@dpvc
Copy link
Member

dpvc commented Dec 6, 2015

OK, I added some more changes that should handle this and some other situations in the issue1312 branch of my fork of MathJax.

More test cases:

\dim\mathrm{im}(f)
\dim\begin{vmatrix}x\end{vmatrix}

@dpvc dpvc reopened this Dec 6, 2015
@dpvc dpvc added Ready for Review and removed Merged Merged into develop branch labels Dec 6, 2015
physikerwelt pushed a commit to physikerwelt/MathJax that referenced this issue Dec 6, 2015
physikerwelt pushed a commit to physikerwelt/MathJax that referenced this issue Dec 6, 2015
physikerwelt added a commit to physikerwelt/MathJax-node that referenced this issue Dec 6, 2015
physikerwelt added a commit to physikerwelt/mathoid-server that referenced this issue Dec 6, 2015
See mathjax/MathJax#1312

Change-Id: Idf410be615d24bf72af08d4bdeca0d9538206871
@physikerwelt
Copy link
Contributor

dpvc added a commit to dpvc/MathJax that referenced this issue Dec 8, 2015
@dpvc
Copy link
Member

dpvc commented Dec 8, 2015

=> Merged

@dpvc dpvc closed this as completed Dec 8, 2015
dpvc added a commit to mathjax/MathJax-test that referenced this issue Dec 8, 2015
@dpvc
Copy link
Member

dpvc commented Dec 8, 2015

Test updated to include new cases.

@dpvc dpvc added Merged Merged into develop branch and removed Test Needed labels Dec 8, 2015
physikerwelt added a commit to physikerwelt/MathJax-node that referenced this issue Dec 17, 2015
@dpvc dpvc added v2.6 Fixed and removed Merged Merged into develop branch labels Jan 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.6
Projects
None yet
Development

No branches or pull requests

3 participants