-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug in "asciimath.js":It cannot run in strict mode, and three global variables are accidentally defined. #2748
Comments
https://github.com/mathjax/MathJax-src/blob/master/ts/input/asciimath/mathjax2/legacy/MathJax.js I found out that the problem is here. |
Sorry for the long delay in getting back to you on this, and thank you for the report. We are putting together a new release, and are collecting together the issues to be resolved; this is certainly one. We appreciate the PRs to fix the global variables, but I've made a separate one as I would like to resolve them in a slightly different way, and so I will be closing your two PR requests based on that. But we do appreciate your willingness to contribute to the project! As for your It is also possible to create your own custom component that combines the ones you need (so that there is only one file to download for your users). See the documentation for making a custom build of MathJax for details. |
Make variables local in legacy code. (mathjax/MathJax#2748)
Issue Summary
A summary of the issue and the browser/OS environment in which it occurs. If
suitable, include the steps required to reproduce the bug.
https://cdn.jsdelivr.net/npm/mathjax@3.2.0/es5/input/asciimath.min.js
bug in "asciimath.js":It cannot run in strict mode, and three global variables are accidentally defined.
"mathfontfamily"
"mathfontsize"
"value"
Steps to Reproduce:
Don't run it in strict mode.
Run it in strict mode.
startup.min.js:5 MathJax(?): Cannot read property 'MmlTree' of undefined
Any other information you want to share that is relevant to the issue
being reported. Especially, why do you consider this to be a bug? What
do you expect to happen instead?
Technical details:
Supporting information:
The text was updated successfully, but these errors were encountered: