Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MathJax not rendering in Chrome when sessionStorage is disabled. #584

Closed
fred-wang opened this issue Sep 25, 2013 · 6 comments
Closed

Fix MathJax not rendering in Chrome when sessionStorage is disabled. #584

fred-wang opened this issue Sep 25, 2013 · 6 comments
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.3
Milestone
MathJax v2.3

Comments

@fred-wang
Copy link
Contributor

See #560
@ghost ghost assigned dpvc Sep 25, 2013
@fred-wang fred-wang mentioned this issue Sep 25, 2013
Closed
@fred-wang
Copy link
Contributor Author

tests:

API/Ajax/Load-1.html
API/Ajax/Load-2.html
API/Ajax/Require-1.html
API/Ajax/Require-2.html

Load-2 and Require-2 fail with Chrome, but I think they already failed in the past. Removing the work around for Chrome does not seem to help much.

@dpvc dpvc mentioned this issue Sep 26, 2013
Closed
@x2b
Copy link

x2b commented Sep 26, 2013

Ok, could you just tell me why you don't merge the fix? It seems to resolve the issue...

@pkra
Copy link
Contributor

pkra commented Sep 26, 2013

It'll be fixed in v2.3. See our wiki for more information on our release process.

@dpvc
Copy link
Member

dpvc commented Sep 26, 2013

could you just tell me why you don't merge the fix?

Because it is likely that the test will be removed entirely in the next release.

dpvc added a commit to dpvc/MathJax that referenced this issue Oct 1, 2013
@dpvc
Remove old Chrome 5-beta test for stylesheet checking, and replace it…
c73c43e 
… with a check for linked stylesheets (which don't currently work -- luckily they are not used). Resolves issue mathjax#584.
@dpvc
Copy link
Member

dpvc commented Oct 1, 2013

OK, the sessionStorage is no longer needed, so I've removed it. But I had to change it to a different test to handle linked stylesheets (this now allows the API tests referenced above to pass). Luckily, linked stylesheets ended up not being used (we thought they would be originally), so it didn't really hurt that they weren't working in Chrome.

=> Ready for Review

@fred-wang
Copy link
Contributor Author

=> Ready For Release

@fred-wang fred-wang mentioned this issue Oct 2, 2013
Merged
dpvc added a commit that referenced this issue Oct 2, 2013
@dpvc
Merge pull request #593 from dpvc/issue584
37c282a 
Resolve issue #584 (and also an issue with loading css files in Chrome)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.3
Projects
None yet
Milestone
MathJax v2.3
Development

No branches or pull requests
4 participants
@pkra @dpvc @fred-wang @x2b