Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MathJax not rendering in Chrome when sessionStorage is disabled. #584

Closed
fred-wang opened this issue Sep 25, 2013 · 6 comments

Comments

Projects
None yet
4 participants
@fred-wang
Copy link
Contributor

commented Sep 25, 2013

See #560

@fred-wang

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2013

tests:

API/Ajax/Load-1.html
API/Ajax/Load-2.html
API/Ajax/Require-1.html
API/Ajax/Require-2.html

Load-2 and Require-2 fail with Chrome, but I think they already failed in the past. Removing the work around for Chrome does not seem to help much.

@x2b

This comment has been minimized.

Copy link

commented Sep 26, 2013

Ok, could you just tell me why you don't merge the fix? It seems to resolve the issue...

@pkra

This comment has been minimized.

Copy link
Member

commented Sep 26, 2013

It'll be fixed in v2.3. See our wiki for more information on our release process.

@dpvc

This comment has been minimized.

Copy link
Member

commented Sep 26, 2013

could you just tell me why you don't merge the fix?

Because it is likely that the test will be removed entirely in the next release.

dpvc pushed a commit to dpvc/MathJax that referenced this issue Oct 1, 2013

Davide P. Cervone
Remove old Chrome 5-beta test for stylesheet checking, and replace it…
… with a check for linked stylesheets (which don't currently work -- luckily they are not used). Resolves issue mathjax#584.
@dpvc

This comment has been minimized.

Copy link
Member

commented Oct 1, 2013

OK, the sessionStorage is no longer needed, so I've removed it. But I had to change it to a different test to handle linked stylesheets (this now allows the API tests referenced above to pass). Luckily, linked stylesheets ended up not being used (we thought they would be originally), so it didn't really hurt that they weren't working in Chrome.

=> Ready for Review

@fred-wang

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2013

=> Ready For Release

dpvc pushed a commit that referenced this issue Oct 2, 2013

Davide P. Cervone
Merge pull request #593 from dpvc/issue584
Resolve issue #584 (and also an issue with loading css files in Chrome)

@fred-wang fred-wang closed this Oct 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.