Retypeset if changes while typesetting #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working with us to make the pull request that conforms to our requirements, and for your work on solving this problem. @pkra, do we need a CLA for this? |
|
@dpvc no need. @jaredwindover do you want to add yourself to the copyright notice? Otherwise, ready to merge. |
|
Nope, I'm good. Feel free to merge. |
pkra
added a commit
that referenced
this pull request
Apr 2, 2015
Retypeset if changes while typesetting
|
Thanks for your contribution, @jaredwindover ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is correct now.
Made changes as per dpvc's suggestions.
Added a flag mjPending to signal that the content has changed while the typesetting was happening. Setting the flag requeues CreatePreview(). This flag is then used for early exit instead of mjRunning This can close #1132.