-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed FLAP's CMakeLists #1
Conversation
Targets should be getting exported properly now. Installation should be correct now too. When you do find_package(FLAP), FACE and PENF are found as well.
With these changes FLAP should be built like
This will install FLAP, PENF, and FACE in |
@LiamBindle Thanks for this. I just got back off of leave and hope I can get to it soon. With ESMF 8 being released, it might be time to do some re-working of Baselibs to start afresh. |
@mathomp4 Sounds good. Let me know if there's anything I can help with! |
Wait. Why am I even waiting. I'm currently building with old make anyway. This has to be better! 👍 |
@LiamBindle One query: did you need to make any changes to my PENF or FACE forks? |
No, I didn't have to make any changes to your PENF or FACE forks |
Surprising, but nice! If I get things working sort of well with my public GitHub baseline, I might ask you to be a test builder. |
Sure, I'd be happy to do that. Just let me know. |
Targets should be getting exported properly now. Installation should be
correct now too. When you do find_package(FLAP), FACE and PENF are found
as well.
I also pass
CMAKE_POSITION_INDEPENDENT_CODE
to the ExternalProjects so FACE and PENF are built with position independent code if FLAP is.