Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed FLAP's CMakeLists #1

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

LiamBindle
Copy link

@LiamBindle LiamBindle commented Oct 1, 2019

Targets should be getting exported properly now. Installation should be
correct now too. When you do find_package(FLAP), FACE and PENF are found
as well.

I also pass CMAKE_POSITION_INDEPENDENT_CODE to the ExternalProjects so FACE and PENF are built with position independent code if FLAP is.

Targets should be getting exported properly now. Installation should be
correct now too. When you do find_package(FLAP), FACE and PENF are found
as well.
@LiamBindle
Copy link
Author

LiamBindle commented Oct 1, 2019

With these changes FLAP should be built like

cd <build directory>
cmake -DCMAKE_INSTALL_PREFIX=<install location> <FLAP's source code>
make -j install

This will install FLAP, PENF, and FACE in <install location>. You can use FLAP in other CMake projects by doing find_package(FLAP). I set it up so that FLAPConfig.cmake gets added to the CMake registry, so you shouldn't have to do anything to get CMake to find FLAPConfig.cmake automatically. If it doesn't find FLAPConfig.cmake automatically, you will have to do cmake -DCMAKE_PREFIX_PATH=<install location> . to point CMake to where you installed FLAP.

@mathomp4
Copy link
Owner

@LiamBindle Thanks for this. I just got back off of leave and hope I can get to it soon. With ESMF 8 being released, it might be time to do some re-working of Baselibs to start afresh.

@LiamBindle
Copy link
Author

@mathomp4 Sounds good. Let me know if there's anything I can help with!

@mathomp4
Copy link
Owner

Wait. Why am I even waiting. I'm currently building with old make anyway. This has to be better! 👍

@mathomp4 mathomp4 merged commit 8c24022 into mathomp4:geos Oct 16, 2019
@mathomp4
Copy link
Owner

@LiamBindle One query: did you need to make any changes to my PENF or FACE forks?

@LiamBindle
Copy link
Author

No, I didn't have to make any changes to your PENF or FACE forks

@mathomp4
Copy link
Owner

Surprising, but nice! If I get things working sort of well with my public GitHub baseline, I might ask you to be a test builder.

@LiamBindle
Copy link
Author

Sure, I'd be happy to do that. Just let me know.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants