Added .text method for the command '*' #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latex for this is \cdot, which makes less sense for the text output. This change makes typed input using '*' compatible with tools like mathjs.
|
|
| CharCmds['*'] = LatexCmds.sdot = LatexCmds.cdot = | ||
| bind(BinaryOperator, '\\cdot ', '·'); | ||
| bind(Times, '\\cdot ', '·'); |
There was a problem hiding this comment.
It looks like BinaryOperator can just take in/be bound a 3rd argument that'll be the text, like https://github.com/mathquill/mathquill/pull/578/files#diff-50c9fc0c437e0937042e370a2e965768R482 , does that work here?
There was a problem hiding this comment.
Yeah, that works for this
laughinghan
added a commit
that referenced
this pull request
Mar 16, 2016
Added .text() method for the command '*'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latex for this is \cdot, which makes less sense for the text output. This change makes typed input using '*' compatible with tools like mathjs.