Kill font-size: 0, fixes many typing issues
#585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Safari on my iPhone 5 running iOS 9.2.1, the blinking blue cursor
doesn't show up at all when focusing and typing in this thing:
http://jsbin.com/sodaji/edit?html,css,js,output
And in all browsers typing in that works just fine, including typing
newlines by pressing Enter or combos like Shift-Enter.
And with this patch, typing on /test/demo.html works great on my iPhone:
(Notice that it's not zoomed wayyyy in, like it used to)
As detailed by #584:
Fixes #540
Fixes #566
Hopefully addresses #559?
laughinghan
changed the title
font-size: 0, fixes many typing issues (#584)font-size: 0, fixes many typing issues
|
|
laughinghan
added a commit
that referenced
this pull request
Mar 22, 2016
Kill `font-size: 0`, fixes many typing issues
charliermarsh
pushed a commit
to Khan/perseus
that referenced
this pull request
Apr 22, 2016
Summary: There has recently been a revival of dev activity in the MathQuill repo. This diff updates Perseus to use the latest version of MathQuill (our own `master` branch @ https://github.com/Khan/mathquill/tree/master). Before, our fork of MathQuill (preserved in the `khan` branch) had 10 commits that were not in the upstream branch. Of those 10 commits: - Four were fixed upstream (8edd85 by mathquill/mathquill#525, 5d7cd2 by mathquill/mathquill#585, a0423f by mathquill/mathquill@ec0aa73, and 4c0c07 by mathquill/mathquill#425). - Two were actually pulled in from upstream in the first place (5a568a2 / 20c436). - One (6f48637) was made obsolete by some different behavior in MathQuill (they no longer break on any "should break sub/sup" characters if they're the first character in the exponent/subscript; not ideal in some cases, but we may be moving away from breaking on the arithmetic characters anyway with the new math input). I did some light testing to verify that these fixes worked as we'd expected. This leaves three commits that I've patched in on top of MathQuill's `master` branch: 1. Khan/mathquill@2160b66 2. Khan/mathquill@7772a97 3. Khan/mathquill@ca60aa2 Now that we're using the updated version of MathQuill, the meat of this diff is that we need to reflect those API differences in `math-input.jsx`. The changes are relatively straightforward. Also worth noting that we'll now be using the `master` branch of https://github.com/Khan/mathquill/, rather than the `khan` branch, which was previously being used for historical reasons. Test Plan: - Run Perseus. - Open up a few Expression widgets in the [editor](http://localhost:9000/test.html#content=%7B%22question%22%3A%7B%22content%22%3A%22%5B%5B%E2%98%83%20expression%201%5D%5D%5Cn%5Cn%5B%5B%E2%98%83%20expression%202%5D%5D%5Cn%5Cn%22%2C%22images%22%3A%7B%7D%2C%22widgets%22%3A%7B%22expression%201%22%3A%7B%22type%22%3A%22expression%22%2C%22alignment%22%3A%22default%22%2C%22static%22%3Afalse%2C%22graded%22%3Atrue%2C%22options%22%3A%7B%22answerForms%22%3A%5B%5D%2C%22buttonSets%22%3A%5B%22basic%22%5D%2C%22functions%22%3A%5B%22f%22%2C%22g%22%2C%22h%22%5D%2C%22times%22%3Afalse%7D%2C%22version%22%3A%7B%22major%22%3A1%2C%22minor%22%3A0%7D%7D%2C%22expression%202%22%3A%7B%22type%22%3A%22expression%22%2C%22alignment%22%3A%22default%22%2C%22static%22%3Afalse%2C%22graded%22%3Atrue%2C%22options%22%3A%7B%22answerForms%22%3A%5B%5D%2C%22buttonSets%22%3A%5B%22basic%22%5D%2C%22functions%22%3A%5B%22f%22%2C%22g%22%2C%22h%22%5D%2C%22times%22%3Afalse%7D%2C%22version%22%3A%7B%22major%22%3A1%2C%22minor%22%3A0%7D%7D%7D%7D%2C%22answerArea%22%3A%7B%22calculator%22%3Afalse%2C%22chi2Table%22%3Afalse%2C%22periodicTable%22%3Afalse%2C%22tTable%22%3Afalse%2C%22zTable%22%3Afalse%7D%2C%22itemDataVersion%22%3A%7B%22major%22%3A0%2C%22minor%22%3A1%7D%2C%22hints%22%3A%5B%5D%7D). - Write a bunch of math in the widgets. Tab between them. Strech the superscript and subscript muscles. - Focus, blur, grade--make sure that the text changes are being preserved by the editor. Reviewers: alex, kevinb Reviewed By: alex, kevinb Subscribers: jared Differential Revision: https://phabricator.khanacademy.org/D26724
xdjinnx
pushed a commit
to DigiExam/mathquill
that referenced
this pull request
May 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #584 "Hide iOS blinking blue cursor without breaking typing in Chrome".
In Safari on my iPhone 5 running iOS 9.2.1, the blinking blue cursor
doesn't show up at all when focusing and typing in this thing:
http://jsbin.com/sodaji/edit?html,css,js,output
And in all browsers typing in that works just fine, including typing
newlines by pressing Enter or combos like Shift-Enter.
And with this patch, typing on
/test/demo.htmlworks great on my iPhone:(Notice that it's not zoomed wayyyy in, like it used to)
As detailed by #584:
Fixes #540
Fixes #566
Hopefully addresses #559?