-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH use weights in penalties #131
Conversation
b3a060e
to
17cf4f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 79.26% 79.80% +0.53%
==========================================
Files 12 12
Lines 1008 1030 +22
Branches 147 148 +1
==========================================
+ Hits 799 822 +23
+ Misses 168 167 -1
Partials 41 41
Continue to review full report at Codecov.
|
3d136a2
to
feb9a1c
Compare
Remains todo: implement weights usage for groups. |
@QB3 this needs a benchmark to check that it does not slow down classic Lasso, but it should be useful for you. |
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 84.35% 84.81% +0.45%
==========================================
Files 12 12
Lines 959 981 +22
Branches 136 137 +1
==========================================
+ Hits 809 832 +23
+ Misses 109 108 -1
Partials 41 41
Continue to review full report at Codecov.
|
This PR:
Master:
There should be a way to automate this on every PR |
paves the way for non convex solvers solved with MM approachs (MCP, AdaptiveLasso)
also allows finer policies in GroupLasso case