Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This PR includes changes to update docs and help text related to pdf test report generation #211

Merged
merged 5 commits into from
Jan 27, 2022
Merged

This PR includes changes to update docs and help text related to pdf test report generation #211

merged 5 commits into from
Jan 27, 2022

Conversation

abhargav-mw
Copy link
Contributor

No description provided.

mw-hrastega
mw-hrastega reviewed Jan 18, 2022
View reviewed changes
CONFIGDOC.md Outdated Show resolved Hide resolved
mw-hrastega
mw-hrastega requested changes Jan 18, 2022
View reviewed changes
Copy link
Member

@mw-hrastega mw-hrastega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anmol. The description of testResultsPDF (in the pipeline arguments table) also needs to be updated.

Another question. Will we update the text for other extensions as well (circleCI, GitHub Actions, Bamboo, etc.)?

@abhargav-mw
Copy link
Contributor Author

@mw-hrastega We will need to update docs on other CI services as well.

mw-hrastega
mw-hrastega requested changes Jan 19, 2022
View reviewed changes
Copy link
Member

@mw-hrastega mw-hrastega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update the text in one more place.

mw-hrastega
mw-hrastega requested changes Jan 20, 2022
View reviewed changes
CONFIGDOC.md Outdated Show resolved Hide resolved
@abhargav-mw abhargav-mw removed the request for review from nbhoski January 27, 2022 09:20
@abhargav-mw abhargav-mw merged commit 6240610 into dev_main Jan 27, 2022
@nbhoski nbhoski deleted the pdf-mac-doc branch July 3, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mw-hrastega mw-hrastega mw-hrastega approved these changes

Assignees

@acampbel acampbel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abhargav-mw @mw-hrastega @acampbel