remove runnerfile from .matlab folder #219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbhoski
requested changes
Aug 8, 2022
| @@ -301,8 +301,8 @@ private int execMatlabCommand(FilePath workspace, Launcher launcher, | |||
| public String constructCommandForTest(FilePath scriptPath) { | |||
| final String matlabScriptName = getValidMatlabFileName(scriptPath.getBaseName()); | |||
| final String runCommand = "addpath('" + scriptPath.getRemote().replaceAll("'", "''") | |||
| + "'); " + matlabScriptName + ",delete('.matlab/" + scriptPath.getBaseName() + "/" | |||
| + matlabScriptName + ".m'),runnerScript,rmdir(tmpDir,'s')"; | |||
| + "');tmpDir=tempname;mkdir(tmpDir), ,movefile('.matlab/" + scriptPath.getBaseName() + "/" | |||
There was a problem hiding this comment.
Why move file here, Cant we keep the runner script as is and just call it here with simple script name
There was a problem hiding this comment.
@dolonm-mw can you pls look into this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the runnerfile from .matlab folder to system temporary folder.