You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the registerProxy macro in the Factory.h assumes that the classname from C++ and MATLAB is the same. We should also consider the scenario where this can be different.
One way to resolve this would be by updating the macro to also accept an optional second argument so that the first argument is the MATLAB packaged class name and the second argument is the C++ class name. Something like this: #define registerProxy(matlabClassName, proxyClassName) if (class_name.compare(#matlabClassName) == 0) return std::make_shared<proxyClassName>(constructor_arguments)
With this, we might also no longer need the extractAfter(classNameWithPackage... call in MATLAB code for Proxy.m.
The text was updated successfully, but these errors were encountered:
Also, update the register proxy macro used to reflect the libmexclass changes for mathworks/libmexclass#20.
Co-authored-by: Fiona la <fionala7@gmail.com>
Also, update the register proxy macro used to reflect the libmexclass changes for mathworks/libmexclass#20.
Co-authored-by: Fiona la <fionala7@gmail.com>
Also, update the register proxy macro used to reflect the libmexclass changes for mathworks/libmexclass#20.
Co-authored-by: Fiona la <fionala7@gmail.com>
Also, update the register proxy macro used to reflect the libmexclass changes for mathworks/libmexclass#20.
Co-authored-by: Fiona la <fionala7@gmail.com>
Currently, the
registerProxy
macro in theFactory.h
assumes that theclassname
from C++ and MATLAB is the same. We should also consider the scenario where this can be different.One way to resolve this would be by updating the macro to also accept an optional second argument so that the first argument is the MATLAB packaged class name and the second argument is the C++ class name. Something like this:
#define registerProxy(matlabClassName, proxyClassName) if (class_name.compare(#matlabClassName) == 0) return std::make_shared<proxyClassName>(constructor_arguments)
With this, we might also no longer need the
extractAfter(classNameWithPackage...
call in MATLAB code forProxy.m
.The text was updated successfully, but these errors were encountered: