Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POS-2399: ganache bug workaround to reduce smoke_test time in CI #1177

Merged
merged 1 commit into from Mar 5, 2024

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Mar 5, 2024

Description

Often, the checkpoints submission during the e2e tests in the CI takes a very long time (35+ mins) due to lack of funds in ganache accounts (with index > 0), which ends up in checkpoints submission failure, and subsequent rotation until it's accounts[0] turn.
This PR introduces a new script to fund the ganache accounts right before the e2e tests, to reduce the checkpoint submission time from 35+ mins to around 2 mins.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@marcello33 marcello33 requested a review from a team March 5, 2024 14:12
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.13%. Comparing base (1ae226b) to head (ae9e4d0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1177      +/-   ##
===========================================
+ Coverage    55.12%   55.13%   +0.01%     
===========================================
  Files          674      674              
  Lines       117323   117323              
===========================================
+ Hits         64679    64691      +12     
+ Misses       48707    48687      -20     
- Partials      3937     3945       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 merged commit 3e999ab into develop Mar 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants