core: remove tracing and handle err in reorg call

[manav2401]

Description

This PR does 2 things:

• Removes tracing in writeBlockAndSetHead function: tracing isn't used anymore and this simplifies the code a lot
• Fixes a bug when the reorg function returns error (when we receive an error we update the status to NonStatTy but don't return at that point. Later the status is updated irrespective of the above error and may lead to wrong processing. This PR fixes that and returns from the function immediately). This change also matches with the upstream implementation of the same function.

Changes

• Bugfix (non-breaking change that solves an issue)
• Hotfix (change that solves an urgent issue, and requires immediate attention)
• New feature (non-breaking change that adds functionality)
• Breaking change (change that is not backwards-compatible and/or changes current functionality)
• Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

• I have added at least 2 reviewer or the whole pos-v1 team
• I have added sufficient documentation in code
• I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
• Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
• Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

• This PR requires changes to heimdall
  • In case link the PR here:
• This PR requires changes to matic-cli
  • In case link the PR here:

Testing

• I have added unit tests
• I have added tests to CI
• I have tested this code manually on local environment
• I have tested this code manually on remote devnet using express-cli
• I have tested this code manually on mumbai
• I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

[pratikspatil024]

Noice!

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.90%. Comparing base (4395894) to head (1c2c7ed).
Report is 1 commits behind head on v1.2.9-beta-candidate.

Files	Patch %	Lines
core/blockchain.go	81.81%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##           v1.2.9-beta-candidate    #1193      +/-   ##
=========================================================
- Coverage                  55.95%   55.90%   -0.05%     
=========================================================
  Files                        658      658              
  Lines                     114496   114459      -37     
=========================================================
- Hits                       64067    63990      -77     
- Misses                     46575    46620      +45     
+ Partials                    3854     3849       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.