Fix state sync hash

[anshalshukla]

Description

Fixes hashing of state sync transactions in RPC calls.

Changes

• Bugfix (non-breaking change that solves an issue)
• Hotfix (change that solves an urgent issue, and requires immediate attention)
• New feature (non-breaking change that adds functionality)
• Breaking change (change that is not backwards-compatible and/or changes current functionality)
• Changes only for a subset of nodes

Checklist

• I have added at least 2 reviewer or the whole pos-v1 team
• I have added sufficient documentation in code
• I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
• Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
• Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

• This PR requires changes to heimdall
  • In case link the PR here:
• This PR requires changes to matic-cli
  • In case link the PR here:

Testing

• I have added unit tests
• I have added tests to CI
• I have tested this code manually on local environment
• I have tested this code manually on remote devnet using express-cli
• I have tested this code manually on mumbai
• I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

[Raneet10]

Can't remember but why aren't we filling state sync receipts here ?

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 51.41%. Comparing base (fd4b9c2) to head (53db521).
Report is 3 commits behind head on v1.3.0-beta-candidate.

❗ Current head 53db521 differs from pull request most recent head c2ad6a6. Consider uploading reports for the commit c2ad6a6 to get more accurate results

Files	Patch %	Lines
internal/ethapi/api.go	60.00%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@                    Coverage Diff                    @@
##           v1.3.0-beta-candidate    #1207      +/-   ##
=========================================================
- Coverage                  51.44%   51.41%   -0.04%     
=========================================================
  Files                        794      794              
  Lines                     131304   131310       +6     
=========================================================
- Hits                       67549    67512      -37     
- Misses                     59576    59619      +43     
  Partials                    4179     4179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cffls]

Is it possible to add a unit test for this fix?

[github-actions]

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[CaraWang]

Hi! Should we append state sync receipt after the expected receipts?

Suggested change

	result := make([]map[string]interface{}, len(receipts))
	for i, receipt := range receipts {
	result[i] = marshalReceipt(receipt, block.Hash(), block.NumberU64(), signer, txs[i], i)
	result[i] = marshalReceipt(receipt, block.Hash(), block.NumberU64(), signer, txs[i], i, false)
	}
	result := make([]map[string]interface{}, len(receipts+1))
	for i, receipt := range receipts {
	result[i] = marshalReceipt(receipt, block.Hash(), block.NumberU64(), signer, txs[i], i, false)
	}
	receipt := rawdb.ReadBorReceipt(s.b.ChainDb(), block.Hash(), block.NumberU64(), s.b.ChainConfig())
	if receipt != nil {
	tx, _, _, _ := rawdb.ReadBorTransaction(s.b,ChainDb(), receipt.TxHash)
	fields := ethapi.MarshalReceipt(receipt, block.Hash(), block.NumberU64(), signer, tx, int(receipt.TransactionIndex), true)
	txReceipts = append(txReceipts, fields)
	}

[tobidae-cb]

Hi, what's the status of this PR?