Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add copy bor binary to go bin command #469

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

manav2401
Copy link
Contributor

@manav2401 manav2401 commented Jul 26, 2022

This PR adds a command to copy bor binary from ./build/bin/bor to go bin.

@manav2401 manav2401 requested a review from a team July 26, 2022 19:05
@codecov-commenter
Copy link

Codecov Report

Merging #469 (fe48a28) into develop (9dcc993) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #469      +/-   ##
===========================================
- Coverage    56.25%   56.14%   -0.12%     
===========================================
  Files          606      603       -3     
  Lines        69846    69823      -23     
===========================================
- Hits         39294    39202      -92     
- Misses       27169    27216      +47     
- Partials      3383     3405      +22     
Impacted Files Coverage Δ
eth/downloader/modes.go 17.24% <0.00%> (-6.90%) ⬇️
node/defaults.go 24.13% <0.00%> (-6.90%) ⬇️
rlp/raw.go 79.37% <0.00%> (-5.63%) ⬇️
core/state/trie_prefetcher.go 74.80% <0.00%> (-5.35%) ⬇️
consensus/ethash/algorithm.go 88.81% <0.00%> (-5.27%) ⬇️
eth/downloader/fetchers.go 61.90% <0.00%> (-4.77%) ⬇️
accounts/keystore/watch.go 90.69% <0.00%> (-4.66%) ⬇️
les/utils/exec_queue.go 88.88% <0.00%> (-2.78%) ⬇️
p2p/discover/table.go 82.48% <0.00%> (-2.56%) ⬇️
core/rawdb/freezer_batch.go 77.21% <0.00%> (-2.54%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dcc993...fe48a28. Read the comment docs.

@manav2401 manav2401 merged commit 8f08503 into develop Jul 27, 2022
@manav2401 manav2401 deleted the manav/update-makefile branch July 27, 2022 16:57
manav2401 added a commit to cffls/bor that referenced this pull request Aug 23, 2022
cffls pushed a commit that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants