Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update matic-cli branch in integration tests #674

Merged
merged 2 commits into from Jan 16, 2023
Merged

Conversation

Raneet10
Copy link
Member

Description

This PR updates matic-cli branch used in CI integration tests to master and also makes subsequent modifications to matic-cli-config.yml

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 56.58% // Head: 56.55% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (af5d882) compared to base (9aeaf03).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #674      +/-   ##
===========================================
- Coverage    56.58%   56.55%   -0.03%     
===========================================
  Files          610      610              
  Lines        71128    71128              
===========================================
- Hits         40247    40226      -21     
- Misses       27426    27452      +26     
+ Partials      3455     3450       -5     
Impacted Files Coverage Δ
core/state_prefetcher.go 85.18% <0.00%> (-7.41%) ⬇️
accounts/keystore/watch.go 90.69% <0.00%> (-4.66%) ⬇️
p2p/discover/v4_udp.go 72.75% <0.00%> (-4.35%) ⬇️
p2p/simulations/mocker.go 32.22% <0.00%> (-3.34%) ⬇️
p2p/enode/nodedb.go 70.46% <0.00%> (-3.11%) ⬇️
les/distributor.go 79.68% <0.00%> (-2.35%) ⬇️
eth/downloader/fetchers_concurrent.go 52.38% <0.00%> (-2.05%) ⬇️
p2p/peer.go 73.63% <0.00%> (-2.00%) ⬇️
consensus/ethash/sealer.go 78.64% <0.00%> (-1.46%) ⬇️
p2p/simulations/http.go 66.02% <0.00%> (-0.65%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Raneet10 Raneet10 requested a review from a team January 16, 2023 08:01
@Raneet10 Raneet10 merged commit e06376c into develop Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants