miner :: add : check to run worker commitWork #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JekaMas
approved these changes
Apr 18, 2023
cffls
approved these changes
Apr 18, 2023
pratikspatil024
approved these changes
Apr 19, 2023
JekaMas
approved these changes
Apr 19, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #828 +/- ##
===========================================
+ Coverage 56.67% 56.68% +0.01%
===========================================
Files 611 611
Lines 72227 72228 +1
===========================================
+ Hits 40933 40942 +9
+ Misses 27805 27794 -11
- Partials 3489 3492 +3
... and 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
cffls
approved these changes
Apr 19, 2023
|
Let's also try to raise this in geth? |
pratikspatil024
added a commit
that referenced
this pull request
Jun 8, 2023
This reverts commit 6dee9b5.
cffls
pushed a commit
to cffls/bor
that referenced
this pull request
Jul 12, 2023
…)" This reverts commit 6dee9b5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we check if the node is running with
--mine/(miner node) , then only we do the resource extensive operations of executing transactions and committing work. On full nodes, these operations shall not take place and hence result in better efficiency of the nodes.