Added check for circular and out-of-range dependency problem #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cffls
reviewed
May 1, 2023
core/parallel_state_processor.go
Outdated
Comment on lines
457
to
459
| if depTx >= n { | ||
| return false | ||
| } |
There was a problem hiding this comment.
If we also enforce depTx < tx here, the circular dependency could be avoided, and we won't need the loop below. wdyt?
There was a problem hiding this comment.
Good point, Jerry. I agree.
cffls
reviewed
May 5, 2023
core/parallel_state_processor.go
Outdated
| // Handle out-of-range and circular dependency problem | ||
| for tx, val := range deps { | ||
| for depTx := range val { | ||
| if depTx >= n && depTx < tx { |
There was a problem hiding this comment.
Should this be || instead of &&?
There was a problem hiding this comment.
My bad, done thanks!
core/parallel_state_processor.go
Outdated
| @@ -304,6 +304,11 @@ func (p *ParallelStateProcessor) Process(block *types.Block, statedb *state.Stat | |||
| metadata = true | |||
| } | |||
|
|
|||
| if !VerifyDeps(deps) { | |||
There was a problem hiding this comment.
If deps is nil or empty, we can skip the check.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## block-stm #841 +/- ##
=============================================
- Coverage 56.79% 56.76% -0.04%
=============================================
Files 617 617
Lines 73603 73602 -1
=============================================
- Hits 41806 41780 -26
- Misses 28262 28286 +24
- Partials 3535 3536 +1
☔ View full report in Codecov by Sentry. |
cffls
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POS-1391 and POS-1392