Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PIP-12, Time Based StateSync Confirmations Delay #864

Merged
merged 9 commits into from Jun 6, 2023

Conversation

pratikspatil024
Copy link
Member

Description

This PR implements PIP-12 Time Based StateSync Confirmations Delay

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

@pratikspatil024 pratikspatil024 marked this pull request as ready for review May 25, 2023 10:03
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 2.70% and project coverage change: -0.05 ⚠️

Comparison is base (f1c8226) 56.88% compared to head (c04dd94) 56.83%.

❗ Current head c04dd94 differs from pull request most recent head c36d0ba. Consider uploading reports for the commit c36d0ba to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #864      +/-   ##
===========================================
- Coverage    56.88%   56.83%   -0.05%     
===========================================
  Files          617      617              
  Lines        73602    73618      +16     
===========================================
- Hits         41871    41844      -27     
- Misses       28196    28239      +43     
  Partials      3535     3535              
Impacted Files Coverage Δ
consensus/bor/bor.go 7.16% <0.00%> (-0.18%) ⬇️
consensus/bor/genesis_contract_mock.go 0.00% <0.00%> (ø)
consensus/bor/span_mock.go 0.00% <0.00%> (ø)
params/config.go 29.52% <0.00%> (-0.29%) ⬇️
graphql/graphql.go 15.52% <50.00%> (ø)

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

internal/ethapi/api.go Show resolved Hide resolved
consensus/bor/bor.go Show resolved Hide resolved
@manav2401 manav2401 requested a review from a team June 6, 2023 07:57
@pratikspatil024 pratikspatil024 merged commit 47f8e86 into develop Jun 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants