Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallel evm by default #867

Merged
merged 2 commits into from May 18, 2023
Merged

Enable parallel evm by default #867

merged 2 commits into from May 18, 2023

Conversation

cffls
Copy link
Contributor

@cffls cffls commented May 16, 2023

Description

Parallel evm speeds up chain sync and import.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@cffls cffls marked this pull request as ready for review May 16, 2023 23:37
@cffls cffls requested review from pratikspatil024 and a team May 16, 2023 23:37
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 ⚠️

Comparison is base (eeb0805) 56.88% compared to head (c7f2701) 56.82%.

❗ Current head c7f2701 differs from pull request most recent head 5cb0d28. Consider uploading reports for the commit 5cb0d28 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #867      +/-   ##
===========================================
- Coverage    56.88%   56.82%   -0.06%     
===========================================
  Files          617      617              
  Lines        73600    73600              
===========================================
- Hits         41865    41821      -44     
- Misses       28197    28232      +35     
- Partials      3538     3547       +9     
Impacted Files Coverage Δ
internal/cli/server/config.go 69.75% <100.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manav2401
Copy link
Contributor

@cffls I think the block-stm PR missed making changes in the docs folder related to the flags which are added. Can we make those changes in this PR itself?

@cffls
Copy link
Contributor Author

cffls commented May 17, 2023

@cffls I think the block-stm PR missed making changes in the docs folder related to the flags which are added. Can we make those changes in this PR itself?

Yes, thanks for the reminder! Added.

@cffls cffls requested a review from manav2401 May 17, 2023 19:38
@cffls cffls merged commit 40a8686 into maticnetwork:develop May 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants