Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: implement milestones #961

Merged
merged 186 commits into from Aug 28, 2023
Merged

all: implement milestones #961

merged 186 commits into from Aug 28, 2023

Conversation

temaniarpit27
Copy link
Contributor

@temaniarpit27 temaniarpit27 commented Aug 14, 2023

Description

Implement milestones - PIP-11

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

VAIBHAVJINDAL3012 and others added 30 commits August 5, 2022 16:48
…ibhav/POS-609

Pull from the develop branch
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 changed the base branch from vaibhav/Milestone to develop August 16, 2023 09:44
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 changed the base branch from develop to vaibhav/Milestone August 16, 2023 09:50
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 changed the base branch from vaibhav/Milestone to vaibhav/MilestoneIteration1 August 16, 2023 14:27
@temaniarpit27 temaniarpit27 changed the base branch from vaibhav/MilestoneIteration1 to develop August 24, 2023 07:13
@temaniarpit27 temaniarpit27 marked this pull request as ready for review August 24, 2023 07:14
@temaniarpit27 temaniarpit27 requested a review from a team August 24, 2023 07:24
@temaniarpit27 temaniarpit27 changed the title Vaibhav/milestone 2 Vaibhav/milestone Aug 24, 2023
@temaniarpit27 temaniarpit27 changed the title Vaibhav/milestone Milestone PR Aug 24, 2023
@temaniarpit27 temaniarpit27 changed the title Milestone PR Milestones Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 32.37% and project coverage change: -0.13% ⚠️

Comparison is base (58729e5) 57.02% compared to head (d6e9bd4) 56.89%.
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #961      +/-   ##
===========================================
- Coverage    57.02%   56.89%   -0.13%     
===========================================
  Files          633      638       +5     
  Lines        77326    77855     +529     
===========================================
+ Hits         44096    44297     +201     
- Misses       29460    29779     +319     
- Partials      3770     3779       +9     
Files Changed Coverage Δ
accounts/abi/bind/backends/bor_simulated.go 7.69% <0.00%> (-0.65%) ⬇️
consensus/bor/api.go 0.00% <0.00%> (ø)
consensus/bor/heimdall/metrics.go 9.09% <ø> (ø)
core/blockchain.go 61.57% <0.00%> (-0.05%) ⬇️
core/blockchain_reader.go 43.84% <0.00%> (-1.40%) ⬇️
core/rawdb/checkpoint.go 0.00% <0.00%> (ø)
core/rawdb/milestone.go 0.00% <0.00%> (ø)
eth/api.go 3.96% <0.00%> (-0.35%) ⬇️
eth/api_backend.go 0.00% <0.00%> (ø)
eth/backend.go 0.00% <0.00%> (ø)
... and 21 more

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manav2401 manav2401 changed the title Milestones all: implement milestones Aug 28, 2023
@manav2401 manav2401 merged commit b48b89f into develop Aug 28, 2023
6 of 8 checks passed
@manav2401 manav2401 deleted the vaibhav/Milestone-2 branch August 28, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants