This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
docker push patch #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purpose:
latest version of goreleaser-cross has no clear way of logging into docker hub directly, breaking automatic release of erigon images. however, latest erigon client code requires go v1.20+ to successfully compile builds. therefore, we've switched the process of uploading new erigon docker images using an additional custom github actions step
the resulting image artifacts (multi architecture) are tagged and grouped identically as the old method, as seen here: https://hub.docker.com/r/0xpolygon/erigon/tags
tests:
e2e github actions test and successful image upload to docker hub, per: https://github.com/maticnetwork/erigon/actions/runs/5316079632/jobs/9625214446