Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gov,types: fix tests #1000

Merged
merged 2 commits into from Jun 8, 2023
Merged

gov,types: fix tests #1000

merged 2 commits into from Jun 8, 2023

Conversation

Raneet10
Copy link
Member

Description

This PR fixes the tests TestParseSubmitProposalFlags,TestValidateBasic and TestNewValidator.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (vaibhav/Milestone@a5545a1). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head efbf823 differs from pull request most recent head 2fd20a2. Consider uploading reports for the commit 2fd20a2 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##             vaibhav/Milestone    #1000   +/-   ##
====================================================
  Coverage                     ?   76.48%           
====================================================
  Files                        ?       53           
  Lines                        ?     5840           
  Branches                     ?        0           
====================================================
  Hits                         ?     4467           
  Misses                       ?     1116           
  Partials                     ?      257           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Raneet10 Raneet10 merged commit b84aac3 into vaibhav/Milestone Jun 8, 2023
12 of 14 checks passed
@Raneet10 Raneet10 deleted the raneet10/test-fixes branch June 8, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants