Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krishna/add graph to self heal #1037

Merged
merged 8 commits into from Sep 10, 2023

Conversation

0xKrishna
Copy link
Contributor

@0xKrishna 0xKrishna commented Aug 20, 2023

Description

This PR will

  • Remove rpc calls from self-heal as they are not working due block range limit
  • Add support for graph for the same
  • Remove redundant and unused code and fix bugs due to which self-heal is not working

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Nodes audience

This will be only used on a couple of internal nodes for self-heal and debugging

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

  • This PR requires changes to bor
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@0xKrishna 0xKrishna changed the base branch from master to develop August 20, 2023 17:13
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c7ec9d5) 75.40% compared to head (320ad3b) 75.40%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1037   +/-   ##
========================================
  Coverage    75.40%   75.40%           
========================================
  Files           49       49           
  Lines         5309     5309           
========================================
  Hits          4003     4003           
  Misses        1071     1071           
  Partials       235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xKrishna 0xKrishna requested a review from a team August 22, 2023 17:05
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 merged commit 2da029a into develop Sep 10, 2023
10 checks passed
@manav2401 manav2401 deleted the krishna/add-graph-to-self-heal branch September 10, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants