Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaibhav/milestone iteration1 #1038

Merged
merged 3 commits into from Aug 24, 2023

Conversation

VAIBHAVJINDAL3012
Copy link
Contributor

Description

This PR contains the following changes:-

  1. Condition that there must be a difference of atleast two Heimdall blocks between two Milestone
  2. Milestone should satisfy block confimation rule in SideHandler

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12% 🎉

Comparison is base (efbf823) 76.48% compared to head (397b508) 76.61%.
Report is 2 commits behind head on vaibhav/Milestone.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           vaibhav/Milestone    #1038      +/-   ##
=====================================================
+ Coverage              76.48%   76.61%   +0.12%     
=====================================================
  Files                     53       53              
  Lines                   5840     5871      +31     
=====================================================
+ Hits                    4467     4498      +31     
  Misses                  1116     1116              
  Partials                 257      257              
Files Changed Coverage Δ
auth/ante.go 82.18% <100.00%> (+0.31%) ⬆️
checkpoint/handler_milestone.go 93.50% <100.00%> (+0.54%) ⬆️
checkpoint/keeper_milestone.go 88.43% <100.00%> (+1.41%) ⬆️
checkpoint/side_milestone_handler.go 94.11% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 merged commit 8c16e6e into vaibhav/Milestone Aug 24, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant