Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine multiple hardforks into one #1039

Merged
merged 2 commits into from Aug 28, 2023
Merged

Conversation

VAIBHAVJINDAL3012
Copy link
Contributor

Description

This PR merges all the following hf
1.GetValidatorSetRotationStopHeight
2.GetMilestoneHardForkHeight()
3.GetNoAckProposerCheckHeight()
into the one single aalborg hf

…kHeight,validatorSetRotationStopHeight into one aalBorg hf
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.02% ⚠️

Comparison is base (8a26699) 76.46% compared to head (917cc03) 76.45%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1039      +/-   ##
===========================================
- Coverage    76.46%   76.45%   -0.02%     
===========================================
  Files           53       53              
  Lines         5915     5911       -4     
===========================================
- Hits          4523     4519       -4     
  Misses        1133     1133              
  Partials       259      259              
Files Changed Coverage Δ
app/app.go 82.68% <0.00%> (ø)
checkpoint/side_milestone_handler.go 93.93% <ø> (-0.18%) ⬇️
auth/ante.go 81.72% <100.00%> (ø)
checkpoint/handler.go 80.15% <100.00%> (ø)
staking/keeper.go 67.88% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 changed the title Merged the following sub hf noAckProposerCheckHeight,milestoneHardFor… Combine multiple hardforks into one Aug 28, 2023
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 merged commit 1056c1d into develop Aug 28, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants