Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkpoint: Fix checkpoint ack condition #1043

Merged
merged 2 commits into from Aug 29, 2023
Merged

checkpoint: Fix checkpoint ack condition #1043

merged 2 commits into from Aug 29, 2023

Conversation

Raneet10
Copy link
Member

Description

This PR fixes condition for checkpoint-ack transaction in post-handler.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13% 🎉

Comparison is base (1056c1d) 76.45% compared to head (116f11f) 76.58%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1043      +/-   ##
===========================================
+ Coverage    76.45%   76.58%   +0.13%     
===========================================
  Files           53       53              
  Lines         5911     5919       +8     
===========================================
+ Hits          4519     4533      +14     
+ Misses        1133     1128       -5     
+ Partials       259      258       -1     
Files Changed Coverage Δ
checkpoint/side_handler.go 73.35% <100.00%> (+2.19%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raneet10 Raneet10 merged commit a53886f into develop Aug 29, 2023
11 checks passed
@Raneet10 Raneet10 deleted the raneet10/cp-bug branch August 29, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants