Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper: use finalized for receipt calculation #1058

Merged
merged 1 commit into from Sep 19, 2023

Conversation

manav2401
Copy link
Contributor

Description

This PR adds the check in receipt calculation to account for finalized tag in main chain (eth). This change was mistakenly removed in the milestone's PR.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 merged commit e34ac72 into v1.0.0-beta-candidate Sep 19, 2023
10 checks passed
@manav2401 manav2401 deleted the manav/add-finalized-check branch September 19, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants